Re: [PATCH 29/31] binfmt_flat: use flush_icache_user_range

Greg Ungerer <gerg@xxxxxxxxxxxxxx> · Wed, 13 May 2020 00:46:55 +1000

Hi Christoph,

On 10/5/20 5:55 pm, Christoph Hellwig wrote:

load_flat_file works on user addresses.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Acked-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>

Regards
Greg




---
  fs/binfmt_flat.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 831a2b25ba79f..6f0aca5379da2 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -854,7 +854,7 @@ static int load_flat_file(struct linux_binprm *bprm,
  #endif /* CONFIG_BINFMT_FLAT_OLD */
  	}

  

-	flush_icache_range(start_code, end_code);

+	flush_icache_user_range(start_code, end_code);

  

  	/* zero the BSS,  BRK and stack areas */

  	if (clear_user((void __user *)(datapos + data_len), bss_len +




