Re: [patch V3 03/20] usb: gadget: Use completion interface instead of open coding it

[Felipe Balbi <balbi@xxxxxxxxxx>]

Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:

> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> ep_io() uses a completion on stack and open codes the waiting with:
>
>   wait_event_interruptible (done.wait, done.done);
> and
>   wait_event (done.wait, done.done);
>
> This waits in non-exclusive mode for complete(), but there is no reason to
> do so because the completion can only be waited for by the task itself and
> complete() wakes exactly one exlusive waiter.
>
> Replace the open coded implementation with the corresponding
> wait_for_completion*() functions.
>
> No functional change.
>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx

Do you want to carry it via your tree? If so:

Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>

Otherwise, let me know and I'll pick this patch.

-- 
balbi

Attachment: signature.asc
Description: PGP signature