RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "'Thomas Gleixner'" <tglx@xxxxxxxxxxxxx>, "'LKML'" <linux-kernel@xxxxxxxxxxxxxxx>
- Subject: RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h
- From: "Brian Cain" <bcain@xxxxxxxxxxxxxx>
- Date: Mon, 23 Mar 2020 16:46:17 -0500
- Cc: "'Peter Zijlstra'" <peterz@xxxxxxxxxxxxx>, "'Ingo Molnar'" <mingo@xxxxxxxxxx>, "'Sebastian Siewior'" <bigeasy@xxxxxxxxxxxxx>, "'Linus Torvalds'" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "'Joel Fernandes'" <joel@xxxxxxxxxxxxxxxxx>, "'Oleg Nesterov'" <oleg@xxxxxxxxxx>, "'Davidlohr Bueso'" <dave@xxxxxxxxxxxx>, "'kbuild test robot'" <lkp@xxxxxxxxx>, <linux-hexagon@xxxxxxxxxxxxxxx>, "'Logan Gunthorpe'" <logang@xxxxxxxxxxxx>, "'Bjorn Helgaas'" <bhelgaas@xxxxxxxxxx>, "'Kurt Schwemmer'" <kurt.schwemmer@xxxxxxxxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, "'Greg Kroah-Hartman'" <gregkh@xxxxxxxxxxxxxxxxxxx>, "'Felipe Balbi'" <balbi@xxxxxxxxxx>, <linux-usb@xxxxxxxxxxxxxxx>, "'Kalle Valo'" <kvalo@xxxxxxxxxxxxxx>, "'David S. Miller'" <davem@xxxxxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, "'Darren Hart'" <dvhart@xxxxxxxxxxxxx>, "'Andy Shevchenko'" <andy@xxxxxxxxxxxxx>, <platform-driver-x86@xxxxxxxxxxxxxxx>, "'Zhang Rui'" <rui.zhang@xxxxxxxxx>, "'Rafael J. Wysocki'" <rafael.j.wysocki@xxxxxxxxx>, <linux-pm@xxxxxxxxxxxxxxx>, "'Len Brown'" <lenb@xxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, "'Nick Hu'" <nickhu@xxxxxxxxxxxxx>, "'Greentime Hu'" <green.hu@xxxxxxxxx>, "'Vincent Chen'" <deanbo422@xxxxxxxxx>, "'Guo Ren'" <guoren@xxxxxxxxxx>, <linux-csky@xxxxxxxxxxxxxxx>, "'Tony Luck'" <tony.luck@xxxxxxxxx>, "'Fenghua Yu'" <fenghua.yu@xxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, "'Michal Simek'" <monstr@xxxxxxxxx>, "'Michael Ellerman'" <mpe@xxxxxxxxxxxxxx>, "'Arnd Bergmann'" <arnd@xxxxxxxx>, "'Geoff Levand'" <geoff@xxxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, "'Paul E . McKenney'" <paulmck@xxxxxxxxxx>, "'Jonathan Corbet'" <corbet@xxxxxxx>, "'Randy Dunlap'" <rdunlap@xxxxxxxxxxxxx>, "'Davidlohr Bueso'" <dbueso@xxxxxxx>
- In-reply-to: <20200321113241.531525286@linutronix.de>
- References: <20200321112544.878032781@linutronix.de> <20200321113241.531525286@linutronix.de>
- Reply-to: <bcain@xxxxxxxxxxxxxx>
> -----Original Message-----
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
...
> Subject: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h
>
> From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
> The defconfig compiles without linux/mm.h. With mm.h included the include
> chain leands to:
> | CC kernel/locking/percpu-rwsem.o
> | In file included from include/linux/huge_mm.h:8,
> | from include/linux/mm.h:567,
> | from arch/hexagon/include/asm/uaccess.h:,
> | from include/linux/uaccess.h:11,
> | from include/linux/sched/task.h:11,
> | from include/linux/sched/signal.h:9,
> | from include/linux/rcuwait.h:6,
> | from include/linux/percpu-rwsem.h:8,
> | from kernel/locking/percpu-rwsem.c:6:
> | include/linux/fs.h:1422:29: error: array type has incomplete element type
> 'struct percpu_rw_semaphore'
> | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
>
> once rcuwait.h includes linux/sched/signal.h.
>
> Remove the linux/mm.h include.
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Brian Cain <bcain@xxxxxxxxxxxxxx>
> Cc: linux-hexagon@xxxxxxxxxxxxxxx
> ---
> V3: New patch
> ---
> arch/hexagon/include/asm/uaccess.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/uaccess.h
> b/arch/hexagon/include/asm/uaccess.h
> index 00cb38faad0c4..c1019a736ff13 100644
> --- a/arch/hexagon/include/asm/uaccess.h
> +++ b/arch/hexagon/include/asm/uaccess.h
> @@ -10,7 +10,6 @@
> /*
> * User space memory access functions
> */
> -#include <linux/mm.h>
> #include <asm/sections.h>
>
> /*
> --
> 2.26.0.rc2
>
Acked-by: Brian Cain <bcain@xxxxxxxxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]