Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Kees Cook <keescook@xxxxxxxxxxxx>
- Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA
- From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- Date: Mon, 11 Nov 2019 17:58:06 +0100
- Cc: Borislav Petkov <bp@xxxxxxxxx>, Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, alpha <linux-alpha@xxxxxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, linux-c6x-dev@xxxxxxxxxxxxx, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Parisc List <linux-parisc@xxxxxxxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <20191011000609.29728-12-keescook@chromium.org>
- References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org>
Hi Kees,
On Fri, Oct 11, 2019 at 2:07 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> There's no reason to keep the RODATA macro: replace the callers with
> the expected RO_DATA macro.
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> arch/alpha/kernel/vmlinux.lds.S | 2 +-
> arch/ia64/kernel/vmlinux.lds.S | 2 +-
> arch/microblaze/kernel/vmlinux.lds.S | 2 +-
> arch/mips/kernel/vmlinux.lds.S | 2 +-
> arch/um/include/asm/common.lds.S | 2 +-
> arch/xtensa/kernel/vmlinux.lds.S | 2 +-
> include/asm-generic/vmlinux.lds.h | 4 +---
> 7 files changed, 7 insertions(+), 9 deletions(-)
Somehow you missed:
arch/m68k/kernel/vmlinux-std.lds: RODATA
arch/m68k/kernel/vmlinux-sun3.lds: RODATA
Leading to build failures in next-20191111:
/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29:
syntax error
make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1
Reported-by: noreply@xxxxxxxxxxxxxx
http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]