Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note"
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Kees Cook <keescook@xxxxxxxxxxxx>
- Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note"
- From: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
- Date: Tue, 29 Oct 2019 20:01:17 -0500
- Cc: Borislav Petkov <bp@xxxxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Michal Simek <monstr@xxxxxxxxx>, x86@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx
- In-reply-to: <201910291414.F29F738B7@keescook>
- References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> <201910110910.48270FC97@keescook> <20191011162552.GK9749@gate.crashing.org> <20191015165412.GD596@zn.tnic> <201910291414.F29F738B7@keescook>
- User-agent: Mutt/1.4.2.3i
On Tue, Oct 29, 2019 at 02:15:39PM -0700, Kees Cook wrote:
> On Tue, Oct 15, 2019 at 06:54:13PM +0200, Borislav Petkov wrote:
> > On Fri, Oct 11, 2019 at 11:25:52AM -0500, Segher Boessenkool wrote:
> > > Names *matter*, internal names doubly so. So why replace a good name with
> > > a worse name? Because it is slightly less work for you?
> >
> > So if we agree on the name "notes" and we decide to rename the other
> > arches, this should all be done in a separate patchset anyway, and ontop
> > of this one. And I believe Kees wouldn't mind doing it ontop since he's
> > gotten his hands dirty already. :-P
>
> I've added more rationale to patch #1 in the just-sent v3 of this
> series. If I still can't convince you Segher, I'm happy to send "patch
> 30/29" to do a bulk rename to "notes". Let me know. :)
I am still not convinced the worse name is a better name, no :-) But if
you don't want to do the work, and instead prefer the much smaller change,
that is of course a fine decision. Thank you!
(I would be happy with such a 30/29 as well, of course.)
Segher
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]