Re: [PATCH] mm/pgtable/debug: Fix test validating architecture page table helpers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Christophe Leroy <christophe.leroy@xxxxxx>, linux-mm@xxxxxxxxx
- Subject: Re: [PATCH] mm/pgtable/debug: Fix test validating architecture page table helpers
- From: Anshuman Khandual <anshuman.khandual@xxxxxxx>
- Date: Wed, 18 Sep 2019 13:02:22 +0530
- Cc: Mark Rutland <mark.rutland@xxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, James Hogan <jhogan@xxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Jason Gunthorpe <jgg@xxxxxxxx>, x86@xxxxxxxxxx, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Steven Price <Steven.Price@xxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, Kees Cook <keescook@xxxxxxxxxxxx>, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, "Kirill A . Shutemov" <kirill@xxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Sri Krishna chowdary <schowdary@xxxxxxxxxx>, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Paul Burton <paul.burton@xxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>, Vineet Gupta <vgupta@xxxxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
- In-reply-to: <1892b37d1fd9a4ed39e76c4b999b6556077201c0.1568355752.git.christophe.leroy@c-s.fr>
- References: <1892b37d1fd9a4ed39e76c4b999b6556077201c0.1568355752.git.christophe.leroy@c-s.fr>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 09/13/2019 11:53 AM, Christophe Leroy wrote:
> Fix build failure on powerpc.
>
> Fix preemption imbalance.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> mm/arch_pgtable_test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/arch_pgtable_test.c b/mm/arch_pgtable_test.c
> index 8b4a92756ad8..f2b3c9ec35fa 100644
> --- a/mm/arch_pgtable_test.c
> +++ b/mm/arch_pgtable_test.c
> @@ -24,6 +24,7 @@
> #include <linux/swap.h>
> #include <linux/swapops.h>
> #include <linux/sched/mm.h>
> +#include <linux/highmem.h>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
>
> @@ -400,6 +401,8 @@ static int __init arch_pgtable_tests_init(void)
> p4d_clear_tests(p4dp);
> pgd_clear_tests(mm, pgdp);
>
> + pte_unmap(ptep);
> +
> pmd_populate_tests(mm, pmdp, saved_ptep);
> pud_populate_tests(mm, pudp, saved_pmdp);
> p4d_populate_tests(mm, p4dp, saved_pudp);
>
Hello Christophe,
I am planning to fold this fix into the current patch and retain your
Signed-off-by. Are you okay with it ?
- Anshuman
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]