Re: [PATCH v4 0/6] normalize IOMMU dma mode boot options
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Leizhen (ThunderTown)" <thunder.leizhen@xxxxxxxxxx>
- Subject: Re: [PATCH v4 0/6] normalize IOMMU dma mode boot options
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Mon, 8 Apr 2019 08:32:50 +0200 (CEST)
- Cc: Hanjun Guo <guohanjun@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx>, John Garry <john.garry@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, linux-doc <linux-doc@xxxxxxxxxxxxxxx>, Sebastian Ott <sebott@xxxxxxxxxxxxx>, Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, iommu <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, x86 <x86@xxxxxxxxxx>, linux-ia64 <linux-ia64@xxxxxxxxxxxxxxx>
- In-reply-to: <5CAABD03.9000301@huawei.com>
- References: <20190407124147.13576-1-thunder.leizhen@huawei.com> <b20fd8a6-88ce-7d26-8eb0-ed9f095988a6@huawei.com> <5CAABD03.9000301@huawei.com>
- User-agent: Alpine 2.21 (DEB 202 2017-01-01)
On Mon, 8 Apr 2019, Leizhen (ThunderTown) wrote:
> >
> > This will break systems using boot options as now, and I think
> > this is unacceptable. If you want to do so, just introduce iommu.dma_mode
> > on top of those iommu boot options with dma mode boot options unchanged,
> > and iommu.dma_mode is for all archs but compatible with them.
>
> I just changed the boot options name, but keep the function no change. I added
> all related maintainers/supporters in the "to=" list, maybe we can disuss this.
Changing the name _IS_ the problem. Think about unattended updates.
> Should I add some "obsoleted" warnings for old options and keep them for a while?
No, just keep the old options around for backwards compatibilty sake. We
just do not add new arch specific options in the future. New options need
to use the generic iommu.dma_mode name space.
Thanks,
tglx
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]