Re: [PATCH 5/6 v3] syscalls: Remove start and number from syscall_get_arguments() args
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Subject: Re: [PATCH 5/6 v3] syscalls: Remove start and number from syscall_get_arguments() args
- From: Max Filippov <jcmvbkbc@xxxxxxxxx>
- Date: Thu, 4 Apr 2019 11:56:23 -0700
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Roland McGrath <roland@xxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "maintainer:X86 ARCHITECTURE..." <x86@xxxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxx>, Dave Martin <dave.martin@xxxxxxx>, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, "moderated list:H8/300 ARCHITECTURE" <uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:QUALCOMM HEXAGON..." <linux-hexagon@xxxxxxxxxxxxxxx>, "open list:IA64 (Itanium) PL..." <linux-ia64@xxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, nios2-dev@xxxxxxxxxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, "open list:PARISC ARCHITECTURE" <linux-parisc@xxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, "open list:SUPERH" <linux-sh@xxxxxxxxxxxxxxx>, "open list:SPARC + UltraSPAR..." <sparclinux@xxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx
- In-reply-to: <20190401134421.278590567@goodmis.org>
- References: <20190401134104.676620247@goodmis.org> <20190401134421.278590567@goodmis.org>
On Mon, Apr 1, 2019 at 6:45 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx>
>
> At Linux Plumbers, Andy Lutomirski approached me and pointed out that the
> function call syscall_get_arguments() implemented in x86 was horribly
> written and not optimized for the standard case of passing in 0 and 6 for
> the starting index and the number of system calls to get. When looking at
> all the users of this function, I discovered that all instances pass in only
> 0 and 6 for these arguments. Instead of having this function handle
> different cases that are never used, simply rewrite it to return the first 6
> arguments of a system call.
>
> This should help out the performance of tracing system calls by ptrace,
> ftrace and perf.
[...]
> arch/xtensa/include/asm/syscall.h | 16 ++----
For xtensa changes:
Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
--
Thanks.
-- Max
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]