Re: [PATCH 00/14] entry: preempt_schedule_irq() callers scrub
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Vineet Gupta <vineet.gupta1@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH 00/14] entry: preempt_schedule_irq() callers scrub
- From: Valentin Schneider <valentin.schneider@xxxxxxx>
- Date: Tue, 12 Mar 2019 18:18:55 +0000
- Cc: Julien Thierry <julien.thierry@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, nios2-dev@xxxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <e604601e-f8e1-a8b5-d364-69ca967996ce@synopsys.com>
- References: <20190311224752.8337-1-valentin.schneider@arm.com> <e604601e-f8e1-a8b5-d364-69ca967996ce@synopsys.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
On 12/03/2019 18:03, Vineet Gupta wrote:
[...]
>> Regarding that loop, archs seem to fall in 3 categories:
>> A) Those that don't have the loop
>
> Please clarify that this is the right thing to do (since core code already has the
> loop) hence no fixing is required for this "category"
>
Right, those don't need any change. I had a brief look at them to double
check they had the proper need_resched() gate before calling
preempt_schedule_irq() (with no loop) and they all seem fine. Also...
>> B) Those that have a small need_resched() loop around the
>> preempt_schedule_irq() callsite
>> C) Those that branch to some more generic code further up the entry code
>> and eventually branch back to preempt_schedule_irq()
>>
>> arc, m68k, nios2 fall in A)
>
I forgot to include parisc in here.
[...]
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]