Re: [PATCH 02/15] swiotlb: remove dma_mark_clean
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Christoph Hellwig <hch@xxxxxx>
- Subject: Re: [PATCH 02/15] swiotlb: remove dma_mark_clean
- From: Tony Luck <tony.luck@xxxxxxxxx>
- Date: Wed, 2 Jan 2019 13:53:33 -0800
- Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, Tariq Toukan <tariqt@xxxxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Toke Høiland-Jørgensen <toke@xxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, X86-ML <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <20181207190720.18517-3-hch@lst.de>
- References: <20181207190720.18517-1-hch@lst.de> <20181207190720.18517-3-hch@lst.de>
On Fri, Dec 7, 2018 at 11:08 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Instead of providing a special dma_mark_clean hook just for ia64, switch
> ia64 to use the normal arch_sync_dma_for_cpu hooks instead.
>
> This means that we now also set the PG_arch_1 bit for pages in the
> swiotlb buffer, which isn't stricly needed as we will never execute code
> out of the swiotlb buffer, but otherwise harmless.
ia64 build based on arch/ia64/configs/zx1_defconfig now fails with undefined
symbols arch_dma_alloc and arch_dma_free (used by kernel/dma/direct.c).
This config doesn't define CONFIG_SWIOTLB, so we don't get the
benefit of the routines in arch/ia64/kernel/dma-mapping.c
-Tony
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]