Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Thierry Reding <thierry.reding@xxxxxxxxx>
- Subject: Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Thu, 20 Dec 2018 17:46:08 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, Tariq Toukan <tariqt@xxxxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Toke Høiland-Jørgensen <toke@xxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20181220164418.GA18777@ulmo>
- References: <20181207190720.18517-1-hch@lst.de> <20181207190720.18517-16-hch@lst.de> <20181220164418.GA18777@ulmo>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Dec 20, 2018 at 05:44:18PM +0100, Thierry Reding wrote:
> On Fri, Dec 07, 2018 at 11:07:20AM -0800, Christoph Hellwig wrote:
> [...]
> > diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
> > index 0b18cfbdde95..fc84c81029d9 100644
> > --- a/kernel/dma/mapping.c
> > +++ b/kernel/dma/mapping.c
> [...]
> > @@ -397,9 +404,9 @@ int dma_supported(struct device *dev, u64 mask)
> > {
> > const struct dma_map_ops *ops = get_dma_ops(dev);
> >
> > - if (!ops)
> > - return 0;
> > - if (!ops->dma_supported)
> > + if (dma_is_direct(ops))
> > + return dma_direct_supported(dev, mask);
> > + if (ops->dma_supported)
> > return 1;
> > return ops->dma_supported(dev, mask);
> > }
>
> Hi Christoph,
>
> This hunk causes a crash on boot for me. It looks like a ! got lost in
> the rework here. The following patch fixes the crash for me and restores
> the logic of the op->dma_supported check.
>
> Feel free to squash this patch into the above if you prefer that.
I don't want to rebase, so I'll pick this up ASAP.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]