Re: [RFC] avoid indirect calls for DMA direct mappings v2
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
- Subject: Re: [RFC] avoid indirect calls for DMA direct mappings v2
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Sat, 8 Dec 2018 17:50:58 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Tariq Toukan <tariqt@xxxxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Toke Høiland-Jørgensen <toke@xxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20181208170648.296fb8a1@redhat.com>
- References: <20181207190720.18517-1-hch@lst.de> <20181208170648.296fb8a1@redhat.com>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Sat, Dec 08, 2018 at 05:06:48PM +0100, Jesper Dangaard Brouer wrote:
> You can add my:
> Tested-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> or
> Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
>
> I'm very happy that you work on this. And I've done micro-benchmark
> testing of the patchset (and branch dma-direct-calls), which I've made
> avail here:
> https://github.com/xdp-project/xdp-project/blob/master/areas/dma/dma01_test_hellwig_direct_dma.org
>
> My XDP performance is back, minus the BPF-indirect call, and
> net_rx_action napi->poll, and net_device->ndo_xdp_xmit calls. I
> verified that manually disabling retpoline for these remaining netstack
> retpoline-calls restore the performance full (well minus 1.5 nanosec).
Thanks a lot for all the testing (and the initial report). I'd love to
still gets this in for 4.21 if we can, but for that I'd need a lot
more folks to carefull review it, especially the swiotlb and ia64 bits.
So if we don't get that early next week I feel we might have to punt
it to the next merge window.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]