Re: [PATCH 01/23] dma-mapping: provide a generic DMA_MAPPING_ERROR
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Robin Murphy <robin.murphy@xxxxxxx>
- Subject: Re: [PATCH 01/23] dma-mapping: provide a generic DMA_MAPPING_ERROR
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 4 Dec 2018 23:33:55 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- In-reply-to: <653ca801-63a1-3c19-ee09-ade19fa2bbb8@arm.com>
- References: <20181130132231.16512-1-hch@lst.de> <20181130132231.16512-2-hch@lst.de> <653ca801-63a1-3c19-ee09-ade19fa2bbb8@arm.com>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Dec 04, 2018 at 04:41:34PM +0000, Robin Murphy wrote:
> I'd have been inclined to put the default check here, i.e.
>
> - return 0
> + return dma_addr == DMA_MAPPING_ERROR
>
> such that the callback retains full precedence and we don't have to deal
> with the non-trivial removals immediately if it comes to it. Not that it
> makes a vast difference though, so either way,
Ok, I've switched it around.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]