Re: [PATCH RFCv2 1/4] mm/memory_hotplug: Introduce memory block types
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: David Hildenbrand <david@xxxxxxxxxx>
- Subject: Re: [PATCH RFCv2 1/4] mm/memory_hotplug: Introduce memory block types
- From: Wei Yang <richard.weiyang@xxxxxxxxx>
- Date: Mon, 3 Dec 2018 20:58:36 +0000
- Cc: Wei Yang <richard.weiyang@xxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Andrew Banman <andrew.banman@xxxxxxx>, "mike.travis@xxxxxxx" <mike.travis@xxxxxxx>, Oscar Salvador <osalvador@xxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Michal Such??nek <msuchanek@xxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Pavel Tatashin <pavel.tatashin@xxxxxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>
- In-reply-to: <af797dbb-0537-19ec-ef31-d72a3f979791@redhat.com>
- References: <20181130175922.10425-1-david@redhat.com> <20181130175922.10425-2-david@redhat.com> <20181201012507.lxfscl6ho3gc6gnn@master> <af797dbb-0537-19ec-ef31-d72a3f979791@redhat.com>
- Reply-to: Wei Yang <richard.weiyang@xxxxxxxxx>
- User-agent: NeoMutt/20170113 (1.7.2)
[...]
>>>
>>> + if (type == MEMORY_BLOCK_NONE)
>>> + return -EINVAL;
>>
>> No one will pass in this value. Can we omit this check for now?
>
>I could move it to patch nr 2 I guess, but as I introduce
>MEMORY_BLOCK_NONE here it made sense to keep it in here.
>
Yes, this make sense to me now.
>(and I think at least for now it makes sense to not squash patch 1 and
>2, to easier discuss the new user interface/concept introduced in this
>patch).
>
>Thanks!
>
>--
>
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]