Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Rob Herring <robh@xxxxxxxxxx>
- Subject: Re: [RFC PATCH 07/29] memblock: remove _virt from APIs returning virtual address
- From: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
- Date: Wed, 5 Sep 2018 20:20:18 +0300
- Cc: linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, mingo@xxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, mhocko@xxxxxxxx, paul.burton@xxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, tony.luck@xxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <CABGGiswdb1x-=vqrgxZ9i2dnLdsgtXq4+5H9Y1JRd90YVMW69A@mail.gmail.com>
- References: <1536163184-26356-1-git-send-email-rppt@linux.vnet.ibm.com> <1536163184-26356-8-git-send-email-rppt@linux.vnet.ibm.com> <CABGGiswdb1x-=vqrgxZ9i2dnLdsgtXq4+5H9Y1JRd90YVMW69A@mail.gmail.com>
- User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Sep 05, 2018 at 12:04:36PM -0500, Rob Herring wrote:
> On Wed, Sep 5, 2018 at 11:00 AM Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > The conversion is done using
> >
> > sed -i 's@memblock_virt_alloc@memblock_alloc@g' \
> > $(git grep -l memblock_virt_alloc)
>
> What's the reason to do this? It seems like a lot of churn even if a
> mechanical change.
I felt that memblock_virt_alloc_ is too long for a prefix, e.g:
memblock_virt_alloc_node_nopanic, memblock_virt_alloc_low_nopanic.
And for consistency I've changed the memblock_virt_alloc as well.
> Rob
>
--
Sincerely yours,
Mike.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]