Re: [PATCH 02/20] kernel/dma/direct: refine dma_direct_alloc zone selection
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 02/20] kernel/dma/direct: refine dma_direct_alloc zone selection
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Thu, 23 Aug 2018 07:26:04 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <d9866d44704073ecc418f62da0ba7587ce7c9af8.camel@kernel.crashing.org>
- References: <20180730163824.10064-1-hch@lst.de> <20180730163824.10064-3-hch@lst.de> <7177553cdb5cd1b968f653a52d7e88bd71aae4d8.camel@kernel.crashing.org> <20180822065856.GC19284@lst.de> <d9866d44704073ecc418f62da0ba7587ce7c9af8.camel@kernel.crashing.org>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Aug 23, 2018 at 10:01:45AM +1000, Benjamin Herrenschmidt wrote:
> > The general scheme that architectures should implement is:
> >
> > ZONE_DMA: Any memory below a magic threshold that is lower than
> > 32-bit. Only enabled if actually required (usually
> > either 24-bit for ISA, or some other weird architecture
> > specific value like 32-bit for S/390)
>
> It should have been ZONE_ISA_DMA :-)
For most of these use cases it should have been indeed, and that
would avoid a lot of confusion where people use GFP_DMA just because
they do DMA.
Anyway, switching powerpc to this scheme would be great, but I don't
think it is required - GFP_KERNEL will silently fall back to ZONE_DMA,
so except for an additional GFP_DMA fallback allocation when the
GFP_KERNEL one fails the code should just work.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]