Re: [PATCH] kbuild: add machine size to CHEKCFLAGS
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Andreas Färber <afaerber@xxxxxxx>, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
- Subject: Re: [PATCH] kbuild: add machine size to CHEKCFLAGS
- From: Rob Landley <rob@xxxxxxxxxxx>
- Date: Wed, 30 May 2018 17:36:45 -0500
- Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, James Hogan <jhogan@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, x86@xxxxxxxxxx, Brendan Higgins <brendanhiggins@xxxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, Cao jin <caoj.fnst@xxxxxxxxxxxxxx>, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>, linux-kbuild@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
- In-reply-to: <d47b72cc-9209-a190-38b3-969870e1bf26@suse.de>
- References: <20180530204838.22079-1-luc.vanoostenryck@gmail.com> <d47b72cc-9209-a190-38b3-969870e1bf26@suse.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
On 05/30/2018 05:00 PM, Andreas Färber wrote:
> What about the architectures not touched by your patch that previously
> had no -m32/-m64? (arc, c6x, h8300, hexagon, m68k, microblaze, nds32,
> nios2, openrisc, powerpc, riscv, s390, sh, unicore32, xtensa)
>
> You forgot to CC them on this patch.
A) He cc'd arch/sh on the previous patch earlier today, to which I replied:
https://marc.info/?l=linux-sh&m=152769132515226&w=2
B) Every change to common infrastructure should cc: every arch? Really? So like
filesystem changes and stuff to?
> Have you really checked that all their toolchains support the -m32/-m64
> flags you newly introduce for them? Apart from non-biarch architectures,
> I'm thinking of 31-bit s390 as a corner case where !64 != 32.
1) Last I heard Linux implements lp64:
http://www.unix.org/whitepapers/64bit.html
2) it's unlikely to be worse than it was before the patch,
3) last I checked https://github.com/landley/mkroot boots to an s390 shell
prompt under qemu, although I haven't tried building with this patch. (And you
may still need to add HOST_EXTRA='lex yacc bison flex' to the command line
unless they've re-added the _shipped versions like the old kconfig had...) Point
is, shouldn't be too hard to test it. Presumably that's why we have an -rc1 and
then 6 more -rc versions each release...
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]