Re: [PATCH] PCI/MSI: Don't set up INTx if MSI or MSI-X is enabled
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] PCI/MSI: Don't set up INTx if MSI or MSI-X is enabled
- From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
- Date: Wed, 14 Mar 2018 12:12:02 -0500
- Authentication-results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
- Authentication-results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@xxxxxxxxxx
- Cc: linux-pci@xxxxxxxxxxxxxxx, Mikael Starvik <starvik@xxxxxxxx>, Jesper Nilsson <jesper.nilsson@xxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, linux-cris-kernel@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-am33-list@xxxxxxxxxx
- Dmarc-filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F1762077B
- In-reply-to: <20180314083519.GA24043@infradead.org>
- References: <152097754955.241946.9551793957889760940.stgit@bhelgaas-glaptop.roam.corp.google.com> <20180314083519.GA24043@infradead.org>
- User-agent: Mutt/1.9.2 (2017-12-15)
On Wed, Mar 14, 2018 at 01:35:19AM -0700, Christoph Hellwig wrote:
> Should this logic go into a little helper so that everyone is kept
> in sync?
Great point, thanks! What I'd really like is to completely get rid of
most of the pcibios_enable_device() implementations. Most of them
contain nothing that's arch-specific.
I'll look at that some more, but will probably do that as additional
steps on top of this one. That way this patch stays mostly trivial
and obvious as a generalization of 16cf0ebc35dd ("x86/PCI: Do not use
interrupt links for devices using MSI-X") to other affected arches.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
