Re: [PATCHv3 6/7] symbol lookup: use new kernel and module dereference functions
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Petr Mladek <pmladek@xxxxxxxx>
- Subject: Re: [PATCHv3 6/7] symbol lookup: use new kernel and module dereference functions
- From: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
- Date: Mon, 23 Oct 2017 17:38:04 +0900
- Cc: Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx>, Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, James Bottomley <jejb@xxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Jessica Yu <jeyu@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20171020130848.GC22070@pathway.suse.cz>
- References: <20170930025319.987-1-sergey.senozhatsky@gmail.com> <20170930025319.987-7-sergey.senozhatsky@gmail.com> <20171004115306.GH20084@pathway.suse.cz> <20171019064235.GB449@jagdpanzerIV> <20171020130848.GC22070@pathway.suse.cz>
- User-agent: Mutt/1.9.1 (2017-09-22)
On (10/20/17 15:08), Petr Mladek wrote:
> On Thu 2017-10-19 15:42:35, Sergey Senozhatsky wrote:
> > Sorry for the delay and thanks for taking a look.
> >
> > I'll try to re-spin the patch set by the end of this week/early next
> > week.
> >
> >
> > On (10/04/17 13:53), Petr Mladek wrote:
> > [..]
> > > Note that kallsyms_lookup() and module_address_lookup() is used
> > > in many other situations.
> >
> > we dereference only things that can be dereferenced.
> > so calling it on already dereferenced address, or address
> > that does need to be dereferenced is OK.
>
> My concern is that it changes the behavior. It will suddenly return
> another information for addresses that were not dereference before.
OK. I'd be really-really surprised to find out that anyone did
kallsyms_lookup()/module_address_lookup() on func descriptors,
but I understand your concerns. I'll try to keep everything
within vsprintf().
-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]