Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Alexander Duyck <alexander.duyck@xxxxxxxxx>
- Subject: Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Sun, 18 Jun 2017 00:09:25 -0700
- Cc: Christoph Hellwig <hch@xxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, "open list:INTEL IOMMU (VT-d)" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <CAKgT0UdxrimWrxNVsLMQ9G6ABBJZwfWHTcP18qqd4rT0Fa-KWg@mail.gmail.com>
- References: <20170616181059.19206-1-hch@lst.de> <20170616181059.19206-4-hch@lst.de> <CAKgT0UdxrimWrxNVsLMQ9G6ABBJZwfWHTcP18qqd4rT0Fa-KWg@mail.gmail.com>
- User-agent: Mutt/1.8.0 (2017-02-23)
On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote:
> dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what
> the compiler is already generating and will save a few lines of code
> so what you end up with is something like:
Honestly wanted to touch the code as little as possible :) If we want
to make it prettier and more readable it needs to be refactored.
If you're interested I can take a stab at that, but I'd like to keep
it out of this already giant series.
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]