Re: [PATCH 06/44] iommu/dma: don't rely on DMA_ERROR_CODE
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Robin Murphy <robin.murphy@xxxxxxx>
- Subject: Re: [PATCH 06/44] iommu/dma: don't rely on DMA_ERROR_CODE
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Fri, 16 Jun 2017 10:37:00 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, x86@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <0bfb0841-f054-78de-628d-a0955336bcb4@arm.com>
- References: <20170608132609.32662-1-hch@lst.de> <20170608132609.32662-7-hch@lst.de> <0bfb0841-f054-78de-628d-a0955336bcb4@arm.com>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Jun 08, 2017 at 02:59:07PM +0100, Robin Murphy wrote:
> Hi Christoph,
>
> On 08/06/17 14:25, Christoph Hellwig wrote:
> > DMA_ERROR_CODE is not a public API and will go away soon. dma dma-iommu
> > driver already implements a proper ->mapping_error method, so it's only
> > using the value internally. Add a new local define using the value
> > that arm64 which is the only current user of dma-iommu.
>
> It would be fine to just use 0, since dma-iommu already makes sure that
> that will never be allocated for a valid DMA address.
I'll change it to 0.
> Otherwise, looks good!
Can you give me a formal ACK or Reviewed-by: ?
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]