On Sun, 9 Apr 2017 11:02:43 +0200 SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > >>> That caused ia64 module loader to choke > >>> on such instructions: > >>> fuse: invalid slot number 1 for IMM64 > >> > >> Why does it matter to check such a value? > > > > I'm not sure I follow the question. Is your question about > > linux kernel relocation code handler, gcc or ia64 instruction format? > > I am just curious if this source code could also work without > the mentioned check. It should work for valid code, yes. The flip side of check removal is to miss malformed relocation (say, when instruction "address" is wrong due to obscure toolchain bug). In this case apply_imm64() would silently corrupt unrelated memory instead of crashing kernel. > Would it make sense to check more than two values there? AFAIU ia64 does not allow encoding imm64/imm60 instructions spanning slot=0 at all. ia64_patch_imm64() can handle only imm64 bundles that span only both slot 1 and slot 2 at the same time. It can accept either slot=1 "address" or slot=2 "address". Anything else would be malformed. -- Sergei
Attachment:
pgpCisJFLsXWX.pgp
Description: Цифровая подпись OpenPGP
|