Re: [PATCH v5 04/14] tables.h: add linker table support

["Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>]

On Thu, Dec 22, 2016 at 03:58:18PM +0200, Andy Shevchenko wrote:
> On Wed, 2016-12-21 at 18:38 -0800, Luis R. Rodriguez wrote:
> > +#define LINKTABLE_FOR_EACH(pointer, tbl)				
> 
> Hmm... SOMEONE LIKES CAPITAL LETTERS FOR everything, right? :-)
>
> I would expect more standard linktable_for_each() macro

hpa had recommended this, if he prefers a lower case I can change that
but I really do consider this bikeshedding.

> Same to the rest of similar macros.

Same answer here.

> > +/**
> > + * LINKTABLE_RUN_ERR - run each linker table entry func and return
> > error if any
> > + *
> > + * @tbl: linker table
> > + * @func: structure name for the function name we want to call.
> > + * @args...: arguments to pass to func
> > + *
> > + * Example usage::
> > + *
> > + *   unsigned int err = LINKTABLE_RUN_ERR(frobnicator_fns,
> > some_run,);
> > + */
> > +#define LINKTABLE_RUN_ERR(tbl, func, args...)				
> > \
> > +({									
> > \
> > +	size_t i;							
> > \
> > +	int err = 0;							
> > \
> > +	for (i = 0; !err && i < LINKTABLE_SIZE(tbl); i++)		
> > \
> > +		err = (LINKTABLE_START(tbl)[i]).func (args);		
> 
> 
> > \
> > +		err;							
> 
> Indentation here a bit confusing.

Ah yes, good catch, fixed.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html