Re: [PATCH v4 04/16] generic-sections: add section core helpers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Subject: Re: [PATCH v4 04/16] generic-sections: add section core helpers
- From: Nicholas Piggin <npiggin@xxxxxxxxx>
- Date: Fri, 26 Aug 2016 23:28:55 +1000
- Cc: benh@xxxxxxxxxxxxxxxxxxx, jani.nikula@xxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx, linux@xxxxxxxxxxxxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, luto@xxxxxxxxxxxxxx, gnomes@xxxxxxxxxxxxxxxxxxx, jcmvbkbc@xxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, dwmw2@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, anil.s.keshavamurthy@xxxxxxxxx, will.deacon@xxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, korea.drzix@xxxxxxxxx, mingo@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, jgross@xxxxxxxx, tglx@xxxxxxxxxxxxx, keescook@xxxxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, jpoimboe@xxxxxxxxxx, rostedt@xxxxxxxxxxx, hpa@xxxxxxxxx, acme@xxxxxxxxxx, arnd@xxxxxxxx, davem@xxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, jkosina@xxxxxxx, david.vrabel@xxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, realmz6@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, ananth@xxxxxxxxxx, paulus@xxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, mchehab@xxxxxxxxxxxxxxx, ak@xxxxxxxxxxxxxxx, pebolle@xxxxxxxxxx, chris@xxxxxxxxxx, jbaron@xxxxxxxxxx, markus.heiser@xxxxxxxxxxx, mmarek@xxxxxxxx, rusty@xxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, catalin.marinas@xxxxxxx, jolsa@xxxxxxxxxx, dvhart@xxxxxxxxxxxxx, msalter@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, ming.lei@xxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, mcb30@xxxxxxxx, heiko.carstens@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, mhiramat@xxxxxxxxxx, bp@xxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxx
- In-reply-to: <20160826132219.GG3296@wotan.suse.de>
- Organization: IBM
- References: <20160823173306.GA3296@wotan.suse.de> <20160824135141.2c8f06ec@roar.ozlabs.ibm.com> <20160824201253.GS3296@wotan.suse.de> <20160825120633.057b2f6f@roar.ozlabs.ibm.com> <20160825060540.GX3296@wotan.suse.de> <20160825165121.45d26fb0@roar.ozlabs.ibm.com> <20160825175239.GB3296@wotan.suse.de> <20160826130024.0ad51d33@roar.ozlabs.ibm.com> <CAB=NE6UQ8qE6AqRg9=YddNYrMyU7opCEij-5Usty7wMgEJJbpw@mail.gmail.com> <20160826173338.41a56103@roar.ozlabs.ibm.com> <20160826132219.GG3296@wotan.suse.de>
On Fri, 26 Aug 2016 15:22:19 +0200
"Luis R. Rodriguez" <mcgrof@xxxxxxxxxx> wrote:
> On Fri, Aug 26, 2016 at 05:33:38PM +1000, Nicholas Piggin wrote:
> > On Thu, 25 Aug 2016 23:38:44 -0700
> > "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx> wrote:
> > > > > > > Ah, thing is we use this for both linktables and section ranges.
> > > > > > > Or do we want macros for both that do the same thing ?
> > > > > >
> > > > > > I think it would make the code using it more readable.
> > > > >
> > > > > Alrighty... so:
> > > > >
> > > > > LINKTABLE_START()
> > > > > LINKTABLE_END()
> > > > >
> > > > > SECTION_RANGE_START()
> > > > > SECTION_RANGE_END()
> > > > >
> > > > > And these macros do the exact same thing. Ie, nothing shared. Right?
> > > >
> > > > Yeah I think so. Internally they would probably be aliased to the
> > > > same common definition (unless you had some type check or something),
> > > > but user would know about such details.
> > >
> > > What name should we use for such common macro definition ?
> >
> >
> > Ah, not really sure. I guess the "link table" is some kind of
> > section range? I haven't actually looked closely at both of them
> > in the subsequent patches. It matters less if it's not expected
> > to be used as an API though.
> >
>
> OK well, going with LINUX_SECTION_START() so we'll have:
>
> #define LINKTABLE_START LINUX_SECTION_START
> #define LINKTABLE_END LINUX_SECTION_END
>
> #define SECTION_RANGE_START LINUX_SECTION_START
> #define SECTION_RANGE_END LINUX_SECTION_END
>
> Is that OK?
I guess so, without having seen the updated, although I don't see why
you'd not just
#define LINKTABLE_START SECTION_RANGE_START
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]