[Re: [PATCH 1/2] ia64: macro-ize ia64_done_with_exception in asm/uaccess.h] On 17/08/2016 (Wed 18:15) Al Viro wrote: > On Tue, Aug 16, 2016 at 11:14:42AM -0400, Paul Gortmaker wrote: > > Most of the other C content in this file is already implemented > > in macro form. Doing the same for this function will allow us > > to get rid of the duplicated search_exception_tables prototype. > > We will bring it in as required via <linux/extable.h> inclusion. > > What is it doing in uaccess.h in the first place? ia64_done_with_exception() > is used only in the guts of arch/ia64 (2 in kernel, 1 in mm), so why dump it > into a widely-used header? Looking at arm and alpha, it seems there are other arch that have exception stuff in their own arch specific uaccess.h file, so I'm guessing it got there in ia64 just by happenstance of copying existing implementations. THere is a precedent for arch specific asm/exception.h -- we could create one for ia64 and move the chunks over there if folks thought that was worthwhile I suppose. Paul. -- -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|