Re: [RFC v3 10/13] jump_label: port __jump_table to linker tables
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Subject: Re: [RFC v3 10/13] jump_label: port __jump_table to linker tables
- From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
- Date: Fri, 22 Jul 2016 16:49:45 -0500
- Cc: hpa@xxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, linux@xxxxxxxxxxxxxxxx, mhiramat@xxxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx, jbaron@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, anil.s.keshavamurthy@xxxxxxxxx, davem@xxxxxxxxxxxxx, realmz6@xxxxxxxxx, x86@xxxxxxxxxx, luto@xxxxxxxxxxxxxx, keescook@xxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, gnomes@xxxxxxxxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxx, dwmw2@xxxxxxxxxxxxx, arnd@xxxxxxxx, ming.lei@xxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, ananth@xxxxxxxxxx, pebolle@xxxxxxxxxx, fontana@xxxxxxxxxxxxxxx, ciaran.farrell@xxxxxxxx, christopher.denicolo@xxxxxxxx, david.vrabel@xxxxxxxxxx, konrad.wilk@xxxxxxxxxx, mcb30@xxxxxxxx, jgross@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ak@xxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, dvhart@xxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, mmarek@xxxxxxxx, linux@xxxxxxxxxxxxxxxxxx, jkosina@xxxxxxx, korea.drzix@xxxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, will.deacon@xxxxxxx, rostedt@xxxxxxxxxxx
- In-reply-to: <1469222687-1600-11-git-send-email-mcgrof@kernel.org>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1469222687-1600-1-git-send-email-mcgrof@kernel.org> <1469222687-1600-11-git-send-email-mcgrof@kernel.org>
- User-agent: Mutt/1.6.0.1 (2016-04-01)
On Fri, Jul 22, 2016 at 02:24:44PM -0700, Luis R. Rodriguez wrote:
> diff --git a/tools/objtool/special.c b/tools/objtool/special.c
> index bff8abb3a4aa..f0ad369f994b 100644
> --- a/tools/objtool/special.c
> +++ b/tools/objtool/special.c
> @@ -26,6 +26,10 @@
> #include "special.h"
> #include "warn.h"
>
> +#include "../../include/asm-generic/sections.h"
> +#include "../../include/asm-generic/tables.h"
> +#include "../../include/linux/stringify.h"
> +
> #define EX_ENTRY_SIZE 12
> #define EX_ORIG_OFFSET 0
> #define EX_NEW_OFFSET 4
> @@ -63,7 +67,9 @@ struct special_entry entries[] = {
> .feature = ALT_FEATURE_OFFSET,
> },
> {
> - .sec = "__jump_table",
> + .sec = __stringify(SECTION_TBL(SECTION_DATA,
> + __jump_table,
> + SECTION_ORDER_ANY)),
> .jump_or_nop = true,
> .size = JUMP_ENTRY_SIZE,
> .orig = JUMP_ORIG_OFFSET,
(continuing our discussion from another thread...)
I think tools code isn't allowed to include kernel files because the
tools subdirectory is supposed to be completely independent.
As far as I can tell, the section name will always be
".data.tbl.__jump_table.any". Is that true? If so, any reason why we
can't just hard-code the string here? As you saw, if the string
changes, objtool will complain and 0-day will report it.
--
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]