Re: [PATCH 09/12] kexec: ensure user memory sizes do not wrap
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 09/12] kexec: ensure user memory sizes do not wrap
- From: Pratyush Anand <panand@xxxxxxxxxx>
- Date: Fri, 29 Apr 2016 20:27:43 +0530
- Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Mark Rutland <mark.rutland@xxxxxxx>, devicetree@xxxxxxxxxxxxxxx, Tony Luck <tony.luck@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, Pawel Moll <pawel.moll@xxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>, kexec@xxxxxxxxxxxxxxxxxxx, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Haren Myneni <hbabu@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Eric Biederman <ebiederm@xxxxxxxxxxxx>, Santosh Shilimkar <ssantosh@xxxxxxxxxx>, Kumar Gala <galak@xxxxxxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>
- In-reply-to: <E1aviFK-0000jY-1S@rmk-PC.arm.linux.org.uk>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20160428092644.GX19428@n2100.arm.linux.org.uk> <E1aviFK-0000jY-1S@rmk-PC.arm.linux.org.uk>
On Thu, Apr 28, 2016 at 2:58 PM, Russell King
<rmk+kernel@xxxxxxxxxxxxxxxx> wrote:
> Ensure that user memory sizes do not wrap around when validating the
> user input, which can lead to the following input validation working
> incorrectly.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> ---
> kernel/kexec_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 8d34308ea449..d719a4d0ef55 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -169,6 +169,8 @@ int sanity_check_segment_list(struct kimage *image)
>
> mstart = image->segment[i].mem;
> mend = mstart + image->segment[i].memsz;
> + if (mstart > mend)
> + return result;
> if ((mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK))
> return result;
> if (mend >= KEXEC_DESTINATION_MEMORY_LIMIT)
Reviewed-by: Pratyush Anand <panand@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]