Re: [PATCH 03/11] locking, rwsem: introduce basis for down_write_killable
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Michal Hocko <mhocko@xxxxxxxxxx>
- Subject: Re: [PATCH 03/11] locking, rwsem: introduce basis for down_write_killable
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Thu, 31 Mar 2016 10:44:12 +0200
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, x86@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx
- In-reply-to: <20160331083336.GA27831@dhcp22.suse.cz>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1456750705-7141-1-git-send-email-mhocko@kernel.org> <1456750705-7141-4-git-send-email-mhocko@kernel.org> <20160330132549.GU3408@twins.programming.kicks-ass.net> <20160331083336.GA27831@dhcp22.suse.cz>
- User-agent: Mutt/1.5.21 (2012-12-30)
On Thu, Mar 31, 2016 at 10:33:36AM +0200, Michal Hocko wrote:
> > __mutex_lock_common() has it before the call to schedule and after the
> > 'trylock'.
> >
> > The difference is that rwsem will now respond to the KILL and return
> > -EINTR even if the lock is available, whereas mutex will acquire it and
> > ignore the signal (for a little while longer).
> >
> > Neither is wrong per se, but I feel all the locking primitives should
> > behave in a consistent manner in this regard.
>
> Agreed! What about the following on top? I will repost the full patch
> if it looks OK.
Yep, that seems to have the right shape to it.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]