Hi Prashanth, On 01/12/15 17:23, Prakash, Prashanth wrote:
Hi Sudeep,+static void combine_lpi_states(struct acpi_processor_lpi *l_lpi, + struct acpi_processor_lpi *p_lpi, + struct acpi_processor_lpi *c_lpi) +{ + c_lpi->min_residency = max(l_lpi->min_residency, p_lpi->min_residency); + c_lpi->wake_latency = l_lpi->wake_latency + p_lpi->wake_latency; + c_lpi->enable_parent_state = p_lpi->enable_parent_state; + c_lpi->entry_method = l_lpi->entry_method; + c_lpi->address = l_lpi->address + p_lpi->address; + c_lpi->index = p_lpi->index; + c_lpi->flags = p_lpi->flags; + c_lpi->arch_flags = p_lpi->arch_flags; + strncpy(c_lpi->desc, l_lpi->desc, ACPI_CX_DESC_LEN); + strncat(c_lpi->desc, "+", ACPI_CX_DESC_LEN); + strncat(c_lpi->desc, p_lpi->desc, ACPI_CX_DESC_LEN); +}I suppose you meant to use strl* instead of strn* operations. Below is a simple patch to fix these. Can you please fold these changes into your next version as well?
Thanks for reporting, I had fixed it already as I ran into same issue when I was playing around with the description string in the LPI tables. Just adding some comments to the code now where ever it's not so obvious, will post it tomorrow. -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|