Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc,free}_noncoherent
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Thu, 13 Aug 2015 19:55:41 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, arnd@xxxxxxxx, catalin.marinas@xxxxxxx, will.deacon@xxxxxxx, ysato@xxxxxxxxxxxxxxxxxxxx, monstr@xxxxxxxxx, jonas@xxxxxxxxxxxx, cmetcalf@xxxxxxxxxx, gxt@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <20150813152040.GQ7557@n2100.arm.linux.org.uk>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1439478248-15183-1-git-send-email-hch@lst.de> <1439478248-15183-3-git-send-email-hch@lst.de> <20150813152040.GQ7557@n2100.arm.linux.org.uk>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Aug 13, 2015 at 04:20:40PM +0100, Russell King - ARM Linux wrote:
> > -/*
> > - * Dummy noncoherent implementation. We don't provide a dma_cache_sync
> > - * function so drivers using this API are highlighted with build warnings.
> > - */
>
> I'd like a similar comment to remain after this patch explaining that we
> don't support non-coherent allocations and that it'll be highlighted by
> the lack of dma_cache_sync, otherwise I'm sure we'll start to get patches
> to add the thing.
I'll keep a modified version of this comment in the ARM dma-mapping.h
in addition to an explanation near the new common dma_alloc_noncoherent
definition, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]