Re: [RFC v1 11/11] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx>
- Subject: Re: [RFC v1 11/11] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked()
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Fri, 15 May 2015 22:48:36 +0200 (CEST)
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Alexandre Courbot <gnurou@xxxxxxxxx>, Michal Simek <michal.simek@xxxxxxxxxx>, Sören Brinkmann <soren.brinkmann@xxxxxxxxxx>, James Hogan <james.hogan@xxxxxxxxxx>, Jason Cooper <jason@xxxxxxxxxxxxxx>, Manuel Lauss <manuel.lauss@xxxxxxxxx>, Marc Zyngier <marc.zyngier@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-metag@xxxxxxxxxxxxxxx
- In-reply-to: <1430709339-29083-12-git-send-email-jiang.liu@linux.intel.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1430709339-29083-1-git-send-email-jiang.liu@linux.intel.com> <1430709339-29083-12-git-send-email-jiang.liu@linux.intel.com>
- User-agent: Alpine 2.11 (DEB 23 2013-08-11)
On Mon, 4 May 2015, Jiang Liu wrote:
> /* caller has locked the irq_desc and both params are valid */
> static inline void
> -__irq_set_chip_handler_name_locked(unsigned int irq, struct irq_chip *chip,
> +__irq_set_chip_handler_name_locked(struct irq_data *data, struct irq_chip *chip,
> irq_flow_handler_t handler, const char *name)
> {
> struct irq_desc *desc;
>
> - desc = irq_to_desc(irq);
> - irq_desc_get_irq_data(desc)->chip = chip;
> + desc = irq_to_desc(data->irq);
We should have a irq_data_to_desc() helper and use that instead of
going through a full lookup again.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]