Re: [PATCH v9 14/30] PCI: Introduce pci_host_bridge_ops to support host specific operations
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Yijing Wang <wangyijing@xxxxxxxxxx>
- Subject: Re: [PATCH v9 14/30] PCI: Introduce pci_host_bridge_ops to support host specific operations
- From: Daniel Axtens <dja@xxxxxxxxxx>
- Date: Tue, 07 Apr 2015 17:04:26 +1000
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Yinghai Lu <yinghai@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Marc Zyngier <marc.zyngier@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Guan Xuetao <gxt@xxxxxxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, Liviu Dudau <liviu@xxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- In-reply-to: <1428053164-28277-16-git-send-email-wangyijing@huawei.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1428053164-28277-1-git-send-email-wangyijing@huawei.com> <1428053164-28277-16-git-send-email-wangyijing@huawei.com>
On Fri, 2015-04-03 at 17:25 +0800, Yijing Wang wrote:
> Now we have weak functions like pcibios_root_bridge_prepare()
> to setup pci host bridge, We could introduce pci_host_bridge_ops
> which contain host bridge specific ops to setup pci_host_bridge.
> Then host bridge driver could add pci_host_bridge_ops hooks
> intead of weak function to setup pci_host_bridge.
> This patch add following pci_host_bridge_ops hooks:
>
> pci_host_bridge_ops {
> struct pci_ops *ops;
Trivial nit, but this is 'struct pci_ops *pci_ops' in the code below.
> +struct pci_host_bridge;
> +struct pci_host_bridge_ops {
> + struct pci_ops *pci_ops;
> + int (*prepare)(struct pci_host_bridge *host);
> + void (*set_root_bus_speed)(struct pci_host_bridge *host);
> + int (*scan_bus)(struct pci_host_bridge *host);
> +};
> +
Regards,
Daniel
Attachment:
signature.asc
Description: This is a digitally signed message part
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]