Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
- Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity
- From: Yijing Wang <wangyijing@xxxxxxxxxx>
- Date: Mon, 19 Jan 2015 11:17:47 +0800
- Cc: Liviu Dudau <liviu@xxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "Russell King" <linux@xxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Marc Zyngier <marc.zyngier@xxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, <linux-m68k@xxxxxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, <linux-alpha@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Guan Xuetao <gxt@xxxxxxxxxxxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>, Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <54BA9052.9080904@cogentembedded.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com>
- User-agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
On 2015/1/18 0:39, Sergei Shtylyov wrote:
> Hello.
>
> On 1/16/2015 4:44 AM, Yijing Wang wrote:
>
>> Use pci_scan_root_bus() instead of pci_create_root_bus() +
>> pci_scan_child_bus() for simplicity.
>
>> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
>> ---
>> drivers/pci/host/pcie-designware.c | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
>> index eef3111..d37fe27 100644
>> --- a/drivers/pci/host/pcie-designware.c
>> +++ b/drivers/pci/host/pcie-designware.c
>> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
>> struct pcie_port *pp = sys_to_pcie(sys);
>>
>> pp->root_bus_nr = sys->busnr;
>> - bus = pci_create_root_bus(pp->dev, sys->busnr,
>> + bus = pci_scan_root_bus(pp->dev, sys->busnr,
>> &dw_pcie_ops, sys, &sys->resources);
>
> Please realign this line, so that it still starts under 'pp'.
ok.
>
> WBR, Sergei
>
>
> .
>
--
Thanks!
Yijing
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]