Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Thierry Reding <thierry.reding@xxxxxxxxx>
- Subject: Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()
- From: Max Filippov <jcmvbkbc@xxxxxxxxx>
- Date: Tue, 30 Sep 2014 14:22:18 +0400
- Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, sparclinux <sparclinux@xxxxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20140929085908.GI12506@ulmo>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1407925738-26170-1-git-send-email-thierry.reding@gmail.com> <1407925738-26170-7-git-send-email-thierry.reding@gmail.com> <CAMuHMdW4emoma3nRUGna985tE17yPh5pNjMb-jxe5yc5UVr=cw@mail.gmail.com> <20140929085908.GI12506@ulmo>
Hi Thierry,
On Mon, Sep 29, 2014 at 12:59 PM, Thierry Reding
<thierry.reding@xxxxxxxxx> wrote:
> On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
>> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
>> <thierry.reding@xxxxxxxxx> wrote:
>> > #ifndef memset_io
>> > -#define memset_io(a, b, c) memset(__io_virt(a), (b), (c))
>> > +#define memset_io memset_io
>> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
>> > +{
>> > + memset(__io_virt(addr), value, size);
>> > +}
>> > #endif
>>
>> xtensa/allmodconfig:
>>
>> include/asm-generic/io.h:820:2: error: implicit declaration of
>> function 'memset' [-Werror=implicit-function-declaration]
>> include/asm-generic/io.h:829:2: error: implicit declaration of
>> function 'memcpy' [-Werror=implicit-function-declaration]
>> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
>> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/
>
> I think this can be fixed by including linux/string.h for memset() and
> memcpy() in include/asm-generic/io.h.
Will you send that fix or do I need to do it?
--
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]