Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Yijing Wang <wangyijing@xxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
- Subject: Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq()
- From: David Vrabel <david.vrabel@xxxxxxxxxx>
- Date: Thu, 11 Sep 2014 14:08:34 +0100
- Cc: <linux-mips@xxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-pci@xxxxxxxxxxxxxxx>, Xinwei Hu <huxinwei@xxxxxxxxxx>, <sparclinux@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, "Joerg Roedel" <joro@xxxxxxxxxx>, <x86@xxxxxxxxxx>, Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <arnab.basu@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <Bharat.Bhushan@xxxxxxxxxxxxx>, "Tony Luck" <tony.luck@xxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Wuyun <wuyun.wu@xxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- In-reply-to: <5410F955.80609@huawei.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-5-git-send-email-wangyijing@huawei.com> <541045BE.9050804@citrix.com> <5410F955.80609@huawei.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0
On 11/09/14 02:22, Yijing Wang wrote:
> On 2014/9/10 20:36, David Vrabel wrote:
>> On 05/09/14 11:09, Yijing Wang wrote:
>>> Commit 0e4ccb150 added two __weak arch functions arch_msix_mask_irq()
>>> and arch_msi_mask_irq() to fix a bug found when running xen in x86.
>>> Introduced these two funcntions make MSI code complex. And mask/unmask
>>> is the irq actions related to interrupt controller, should not use
>>> weak arch functions to override mask/unmask interfaces. This patch
>>> reverted commit 0e4ccb150 and export struct irq_chip msi_chip, modify
>>> msi_chip->irq_mask/irq_unmask() in xen init functions to fix this
>>> bug for simplicity. Also this is preparation for using struct
>>> msi_chip instead of weak arch MSI functions in all platforms.
>>
>> Acked-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>>
>> But I wonder if it would be better the Xen subsystem to provide its own
>> struct irq_chip instead of adjusting the fields in the generic x86 one.
>
> Thanks! Currently, Xen and the bare x86 system only have the different irq_chip->irq_mask/irq_unmask.
> So I chose to override the two ops of bare x86 irq_chip in xen. Konrad Rzeszutek Wilk has been tested it
> ok in his platform, so I think we could use its own irq_chip for xen later if the difference become large.
This sounds reasonable.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]