RE: [PATCH 00/13] Refactor pci_is_brdige() to simplify code
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "'Yijing Wang'" <wangyijing@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
- Subject: RE: [PATCH 00/13] Refactor pci_is_brdige() to simplify code
- From: David Laight <David.Laight@xxxxxxxxxx>
- Date: Fri, 25 Apr 2014 09:42:45 +0000
- Accept-language: en-GB, en-US
- Cc: Tony Luck <tony.luck@xxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "sparclinux@xxxxxxxxxxxxxxx" <sparclinux@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- In-reply-to: <1398417515-8740-1-git-send-email-wangyijing@huawei.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1398417515-8740-1-git-send-email-wangyijing@huawei.com>
- Thread-index: AQHPYGiv0jVusWLreUyzlUfzy7AoB5siE9MQ
- Thread-topic: [PATCH 00/13] Refactor pci_is_brdige() to simplify code
From: Yijing Wang
> This patchset rename the current pci_is_bridge() to pci_has_subordinate(),
> and introduce a new pci_is_bridge() which determine pci bridge by check
> dev->hdr_type. The new one is more accurate. PCIe Spec define the pci
> device is a bridge by the dev->hdr_type = 0x01 || 0x02.
That is a dangerous rename and is likely to cause difficult to
identify bugs in any code you've missed.
David
��.n��������+%������w��{.n�����{��&�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
