Re: [PATCH v3 2/5] efi: Export arch_tables variable
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Daniel Kiper" <daniel.kiper@xxxxxxxxxx>
- Subject: Re: [PATCH v3 2/5] efi: Export arch_tables variable
- From: "Jan Beulich" <JBeulich@xxxxxxxx>
- Date: Wed, 26 Mar 2014 13:21:19 +0000
- Cc: <david.vrabel@xxxxxxxxxx>, <ian.campbell@xxxxxxxxxx>, <stefano.stabellini@xxxxxxxxxxxxx>, <jeremy@xxxxxxxx>, <fenghua.yu@xxxxxxxxx>, <matt.fleming@xxxxxxxxx>, <tony.luck@xxxxxxxxx>, <x86@xxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <boris.ostrovsky@xxxxxxxxxx>, <konrad.wilk@xxxxxxxxxx>, <eshelton@xxxxxxxxx>, <mingo@xxxxxxxxxx>, <linux-efi@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <hpa@xxxxxxxxx>
- In-reply-to: <1395781076-12000-3-git-send-email-daniel.kiper@oracle.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1395781076-12000-1-git-send-email-daniel.kiper@oracle.com> <1395781076-12000-3-git-send-email-daniel.kiper@oracle.com>
>>> On 25.03.14 at 21:57, <daniel.kiper@xxxxxxxxxx> wrote:
> Export arch_tables variable. Xen init function calls efi_config_init()
> which takes it as an argument.
>
> Additionally, put __initdata in place suggested by include/linux/init.h.
Which isn't necessarily the most appropriate place.
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -70,7 +70,7 @@ static efi_system_table_t efi_systab __initdata;
>
> unsigned long x86_efi_facility;
>
> -static __initdata efi_config_table_type_t arch_tables[] = {
> +efi_config_table_type_t arch_tables[] __initdata = {
efi_config_table_type_t __initdata arch_tables[] = {
would be what I'd recommend.
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -583,6 +583,8 @@ extern struct efi {
> struct efi_memory_map *memmap;
> } efi;
>
> +extern efi_config_table_type_t arch_tables[] __initdata;
And section placement annotations are bogus on declarations.
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]