Re: [PATCH v3 3/5] x86: Call efi_memblock_x86_reserve_range() on native EFI platform only
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- Subject: Re: [PATCH v3 3/5] x86: Call efi_memblock_x86_reserve_range() on native EFI platform only
- From: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
- Date: Wed, 26 Mar 2014 13:00:09 +0000
- Cc: linux-efi@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, david.vrabel@xxxxxxxxxx, eshelton@xxxxxxxxx, fenghua.yu@xxxxxxxxx, hpa@xxxxxxxxx, ian.campbell@xxxxxxxxxx, jbeulich@xxxxxxxx, jeremy@xxxxxxxx, konrad.wilk@xxxxxxxxxx, matt.fleming@xxxxxxxxx, mingo@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, tony.luck@xxxxxxxxx
- In-reply-to: <1395781076-12000-4-git-send-email-daniel.kiper@oracle.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1395781076-12000-1-git-send-email-daniel.kiper@oracle.com> <1395781076-12000-4-git-send-email-daniel.kiper@oracle.com>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, 25 Mar, at 09:57:54PM, Daniel Kiper wrote:
> Call efi_memblock_x86_reserve_range() on native EFI platform only.
> This is not needed and even it should not be called on platforms
> which wraps EFI infrastructure like Xen.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
> arch/x86/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index ce72964..992b67a 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -933,7 +933,7 @@ void __init setup_arch(char **cmdline_p)
> set_bit(EFI_64BIT, &x86_efi_facility);
> }
>
> - if (efi_enabled(EFI_BOOT))
> + if (!strncmp((char *)&boot_params.efi_info.efi_loader_signature, "EL", 2))
> efi_memblock_x86_reserve_range();
> #endif
This could do with a little bit more explanation. Why is it not
necessary to mark the EFI memory map that was passed to the kernel as
reserved in memblock?
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]