Re: [PATCH v3 06/27] ia64, irq: Add dummy create_irq_nr()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 06/27] ia64, irq: Add dummy create_irq_nr()
- From: Yinghai Lu <yinghai@xxxxxxxxxx>
- Date: Mon, 10 Jun 2013 16:41:40 -0700
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>
- In-reply-to: <20130609152259.GC2245@breakpoint.cc>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1370644273-10495-1-git-send-email-yinghai@kernel.org> <1370644273-10495-7-git-send-email-yinghai@kernel.org> <20130609152259.GC2245@breakpoint.cc>
On Sun, Jun 9, 2013 at 8:22 AM, Sebastian Andrzej Siewior
<sebastian@xxxxxxxxxxxxx> wrote:
> On Fri, Jun 07, 2013 at 03:30:52PM -0700, Yinghai Lu wrote:
>> create_irq() will return -1 when fail to allocate.
> The ia64 code here will return -ENOSPC.
>
>> create_irq_nr() will return 0 when fail to allocate.
>>
>> Will use it to fix one return value checking for dmar_msi irq.
>
> What about to unify the interface? Using -1 is kinda bad.
after some following patch, create_irq() in x86 get killed.
Still need ia64 guys to kill create_irq() in arch/ia64.
Thanks
Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]