Re: [PATCH][RESEND] [IA64] tiocx: check retval from bus_register()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 19 Mar 2013, Jiri Kosina wrote:

> Properly check return value from bus_register() and propagate it out of 
> tiocx_init() in case of failure.
> 
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

Is anyone please going to apply/nack this, please?

Thanks.

> ---
>  arch/ia64/sn/kernel/tiocx.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/ia64/sn/kernel/tiocx.c b/arch/ia64/sn/kernel/tiocx.c
> index 14c1711..e35f648 100644
> --- a/arch/ia64/sn/kernel/tiocx.c
> +++ b/arch/ia64/sn/kernel/tiocx.c
> @@ -490,11 +490,14 @@ static int __init tiocx_init(void)
>  {
>  	cnodeid_t cnodeid;
>  	int found_tiocx_device = 0;
> +	int err;
>  
>  	if (!ia64_platform_is("sn2"))
>  		return 0;
>  
> -	bus_register(&tiocx_bus_type);
> +	err = bus_register(&tiocx_bus_type);
> +	if (err)
> +		return err;
>  
>  	for (cnodeid = 0; cnodeid < num_cnodes; cnodeid++) {
>  		nasid_t nasid;
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux