Re: [PATCH v3 1/2] memory-hotplug: introduce CONFIG_HAVE_BOOTMEM_INFO_NODE and revert register_page_bootmem_info_node() when platform not support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Michal Hocko <mhocko@xxxxxxx>
- Subject: Re: [PATCH v3 1/2] memory-hotplug: introduce CONFIG_HAVE_BOOTMEM_INFO_NODE and revert register_page_bootmem_info_node() when platform not support
- From: Lin Feng <linfeng@xxxxxxxxxxxxxx>
- Date: Fri, 18 Jan 2013 15:58:27 +0800
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, jbeulich@xxxxxxxx, dhowells@xxxxxxxxxx, wency@xxxxxxxxxxxxxx, isimatu.yasuaki@xxxxxxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, laijs@xxxxxxxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, mel@xxxxxxxxx, minchan@xxxxxxxxxx, aquini@xxxxxxxxxx, jiang.liu@xxxxxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, schwidefsky@xxxxxxxxxx, heiko.carstens@xxxxxxxxxx, davem@xxxxxxxxxxxxx, michael@xxxxxxxxxxxxxx, gerald.schaefer@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux390@xxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tangchen@xxxxxxxxxxxxxx
- In-reply-to: <20130117130509.GE20538@dhcp22.suse.cz>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1358324059-9608-1-git-send-email-linfeng@cn.fujitsu.com> <1358324059-9608-2-git-send-email-linfeng@cn.fujitsu.com> <20130116141436.GE343@dhcp22.suse.cz> <50F7D456.9000904@cn.fujitsu.com> <20130117130509.GE20538@dhcp22.suse.cz>
- User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
Hi Michal,
On 01/17/2013 09:05 PM, Michal Hocko wrote:
> On Thu 17-01-13 18:37:10, Lin Feng wrote:
> [...]
>>> > > I am still not sure I understand the relation to MEMORY_HOTREMOVE.
>>> > > Is register_page_bootmem_info_node required/helpful even if
>>> > > !CONFIG_MEMORY_HOTREMOVE?
>> > From old kenrel's view register_page_bootmem_info_node() is defined in
>> > CONFIG_MEMORY_HOTPLUG_SPARSE, it registers some info for
>> > memory hotplug/remove. If we don't use MEMORY_HOTPLUG feature, this
>> > function is empty, we don't need the info at all.
>> > So this info is not required/helpful if !CONFIG_MEMORY_HOTREMOVE.
> OK, then I suggest moving it under CONFIG_MEMORY_HOTREMOVE guards rather
> than CONFIG_MEMORY_HOTPLUG.
I can't agree more ;-)
I also find that page_isolation.c selected by MEMORY_ISOLATION under MEMORY_HOTPLUG
is also such case, I fix it by the way.
thanks,
linfeng
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]