Re: [PATCH v2 2/2] PCI: Provide a default pcibios_update_irq()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v2 2/2] PCI: Provide a default pcibios_update_irq()
- From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
- Date: Thu, 20 Sep 2012 08:37:31 +1000
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Paul Mundt <lethal@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Guan Xuetao <gxt@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, x86@xxxxxxxxxx, Chris Zankel <chris@xxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx
- In-reply-to: <1347880974-13615-2-git-send-email-thierry.reding@avionic-design.de>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1347880974-13615-1-git-send-email-thierry.reding@avionic-design.de> <1347880974-13615-2-git-send-email-thierry.reding@avionic-design.de>
Hi,
On Mon, 17 Sep 2012 13:22:54 +0200 Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
>
> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
> index 270ae7b..3d61ce3 100644
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -17,6 +17,11 @@
> #include <linux/ioport.h>
> #include <linux/cache.h>
>
> +void __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> +{
> + dev_dbg(&dev->dev, "Assigning IRQ %02d\n", irq);
> + pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
> +}
>
> static void
> pdev_fixup_irq(struct pci_dev *dev,
Didn't we have a problem with some compiler versions when the weak
definition was in the same file as the call (there is a call to this
function in drivers/pci/setup-irq.c)?
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgp2Si7v3VIRY.pgp
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]