Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs
- From: Wen Congyang <wency@xxxxxxxxxxxxxx>
- Date: Wed, 05 Sep 2012 09:41:06 +0800
- Cc: x86@xxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, cmetcalf@xxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, rientjes@xxxxxxxxxx, liuj97@xxxxxxxxx, len.brown@xxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, cl@xxxxxxxxx, minchan.kim@xxxxxxxxx, kosaki.motohiro@xxxxxxxxxxxxxx, isimatu.yasuaki@xxxxxxxxxxxxxx, Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20120904161634.f1f9f693.akpm@linux-foundation.org>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1346148027-24468-1-git-send-email-wency@cn.fujitsu.com> <1346148027-24468-9-git-send-email-wency@cn.fujitsu.com> <20120831140623.8d13bd2c.akpm@linux-foundation.org> <5044454E.7070909@cn.fujitsu.com> <20120904161634.f1f9f693.akpm@linux-foundation.org>
- User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4
At 09/05/2012 07:16 AM, Andrew Morton Wrote:
> On Mon, 03 Sep 2012 13:51:10 +0800
> Wen Congyang <wency@xxxxxxxxxxxxxx> wrote:
>
>>>> +static void release_firmware_map_entry(struct kobject *kobj)
>>>> +{
>>>> + struct firmware_map_entry *entry = to_memmap_entry(kobj);
>>>> + struct page *page;
>>>> +
>>>> + page = virt_to_page(entry);
>>>> + if (PageSlab(page) || PageCompound(page))
>>>
>>> That PageCompound() test looks rather odd. Why is this done?
>>
>> Liu Jiang and Christoph Lameter discussed how to find slab page
>> in this mail:
>> https://lkml.org/lkml/2012/7/6/333.
>
> Well, please add a code comment to release_firmware_map_entry() which
> fully explains these things.
>
> I see that Christoph and I agree: "It would be cleaner if memory
> hotplug had an indicator which allocation mechanism was used and would
> use the corresponding free action". You didn't respond to this
> suggestion when he made it, nor when I made it. What are your thoughts
> on this?
Hmm, I think it is better to use an indicator which allocation mechanism was
used. I will do it in the next version.
Thanks
Wen Congyang
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]