Re: [PATCH 12/24] PCI, ia64: Register busn_res for root buses
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Yinghai Lu <yinghai@xxxxxxxxxx>
- Subject: Re: [PATCH 12/24] PCI, ia64: Register busn_res for root buses
- From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
- Date: Tue, 28 Feb 2012 17:22:46 -0700
- Authentication-results: mr.google.com; spf=pass (google.com: domain of bhelgaas@xxxxxxxxxx designates 10.216.139.25 as permitted sender) smtp.mail=bhelgaas@xxxxxxxxxx; dkim=pass header.i=bhelgaas@xxxxxxxxxx
- Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, x86 <x86@xxxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <CAE9FiQWBvYZO-D+Z2zwdd0a-bkatF-0YPtmxKP4Se75vccgPrA@mail.gmail.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1330466863-28469-1-git-send-email-yinghai@kernel.org> <1330466863-28469-13-git-send-email-yinghai@kernel.org> <CAErSpo66PD3+E3ZFqp73XHabL+8GavpX97pUkd28T6KWTBH-aA@mail.gmail.com> <CAE9FiQWBvYZO-D+Z2zwdd0a-bkatF-0YPtmxKP4Se75vccgPrA@mail.gmail.com>
On Tue, Feb 28, 2012 at 5:12 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Tue, Feb 28, 2012 at 4:01 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> On Tue, Feb 28, 2012 at 3:07 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>> Cc: Tony Luck <tony.luck@xxxxxxxxx>
>>> Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>>> Cc: linux-ia64@xxxxxxxxxxxxxxx
>>> ---
>>> arch/ia64/include/asm/pci.h | 1 +
>>> arch/ia64/pci/pci.c | 5 +++++
>>> 2 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/ia64/include/asm/pci.h b/arch/ia64/include/asm/pci.h
>>> index b22e5f5..6e54220 100644
>>> --- a/arch/ia64/include/asm/pci.h
>>> +++ b/arch/ia64/include/asm/pci.h
>>> @@ -94,6 +94,7 @@ struct pci_controller {
>>>
>>> unsigned int windows;
>>> struct pci_window *window;
>>> + struct resource busn;
>>
>> Why do you add a new struct resource here? Can't you just use the one
>> passed in from acpi_pci_root_add()?
>
> not quite sure about the life cycle for that object.
The struct acpi_pci_root is allocated in acpi_pci_root_add() and freed
in acpi_pci_root_remove(), so it should be safe for PCI to use.
Same thing applies for x86, of course.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]