Re: [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v5
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Srivatsa S. Bhat" <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v5
- From: Tony Luck <tony.luck@xxxxxxxxx>
- Date: Tue, 14 Feb 2012 15:00:43 -0800
- Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Venkatesh Pallipadi <venki@xxxxxxxxxx>, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxx>, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>, Mike Travis <travis@xxxxxxx>, "Paul E. McKenney" <paul.mckenney@xxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <4F3AD3B6.8070409@linux.vnet.ibm.com>
- List-id: <linux-ia64.vger.kernel.org>
- References: <CABeCy1aPp4=v90v_wAsw-KWDwNs59CwwYSJ-36+4t8kMuCaK0w@mail.gmail.com> <1328055439-9441-1-git-send-email-venki@google.com> <20120201140125.c656df41.akpm@linux-foundation.org> <87d39xj955.fsf@rustcorp.com.au> <CA+8MBbJcTgj7X-7RZAgWk8a3Qyaz1FxFzu3ZLk-8LHKD7M8h-Q@mail.gmail.com> <4F3971A1.5010305@linux.vnet.ibm.com> <4F39763D.3070609@linux.vnet.ibm.com> <CA+8MBbLR+rcJqe2z9tAt7Oav4wqgZA3k8Te6zcXNOs+zv2wAaA@mail.gmail.com> <87wr7pbwbz.fsf@rustcorp.com.au> <4F3AD3B6.8070409@linux.vnet.ibm.com>
On Tue, Feb 14, 2012 at 1:35 PM, Srivatsa S. Bhat
<srivatsa.bhat@xxxxxxxxxxxxxxxxxx> wrote:
> Right. And we should also ensure that nobody messes directly with
> cpu_possible_map as well. I have written up a patch for ia64 (see below).
> Sorry, I haven't even compile tested it - I neither have the toolchain nor the
> hardware. I hope it works!
Thanks for doing this - compiles and seems to work.
Tested-by: Tony Luck <tony.luck@xxxxxxxxx>
Can we get this added to the series - so it gets applied along with
Venki's patch.
> 0 files changed, 0 insertions(+), 0 deletions(-)
I think your patch generation script needs some attention - I see
arch/ia64/kernel/setup.c | 2 +-
arch/ia64/kernel/smp.c | 2 +-
arch/ia64/kernel/smpboot.c | 12 ++++++------
3 files changed, 8 insertions(+), 8 deletions(-)
> @@ -609,7 +609,7 @@ smp_prepare_cpus (unsigned int max_cpus)
> /*
> * We have the boot CPU online for sure.
> */
> - cpu_set(0, cpu_online_map);
> + set_cpu_online(0, true);
> cpu_set(0, cpu_callin_map);
>
> local_cpu_data->loops_per_jiffy = loops_per_jiffy;
Generic code has already marked cpu 0 online ... so this one could
just be dropped (and the preceding comment too). Though it does no
harm to set it again.
-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]