Re: [PATCH 01/14] common: dma-mapping: introduce alloc_attrs and free_attrs methods
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
- Subject: Re: [PATCH 01/14] common: dma-mapping: introduce alloc_attrs and free_attrs methods
- From: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 16 Jan 2012 12:57:10 +1100
- Cc: linux-kernel@xxxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, microblaze-uclinux@xxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, discuss@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linaro-mm-sig@xxxxxxxxxxxxxxxx, Jonathan Corbet <corbet@xxxxxxx>, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
- In-reply-to: <1324643253-3024-2-git-send-email-m.szyprowski@samsung.com>
- List-id: <linux-ia64.vger.kernel.org>
- Mail-followup-to: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, microblaze-uclinux@xxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, discuss@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linaro-mm-sig@xxxxxxxxxxxxxxxx, Jonathan Corbet <corbet@xxxxxxx>, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
- References: <1324643253-3024-1-git-send-email-m.szyprowski@samsung.com> <1324643253-3024-2-git-send-email-m.szyprowski@samsung.com>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Dec 23, 2011 at 01:27:20PM +0100, Marek Szyprowski wrote:
> Introduce new generic alloc and free methods with attributes argument.
>
> Existing alloc_coherent and free_coherent can be implemented on top of the
> new calls with NULL attributes argument. Later also dma_alloc_non_coherent
> can be implemented using DMA_ATTR_NONCOHERENT attribute as well as
> dma_alloc_writecombine with separate DMA_ATTR_WRITECOMBINE attribute.
>
> This way the drivers will get more generic, platform independent way of
> allocating dma buffers with specific parameters.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
Looks sensible to me.
Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]