Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE
- From: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
- Date: Thu, 23 Jun 2011 16:05:57 +0100
- Cc: Martyn Welch <martyn.welch@xxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxx>, devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, David Howells <dhowells@xxxxxxxxxx>, linux-m32r@xxxxxxxxxxxxxxxxx, linux-m32r-ja@xxxxxxxxxxxxxxxxx, linux-am33-list@xxxxxxxxxx, Paul Mundt <lethal@xxxxxxxxxxxx>, linux-sh@xxxxxxxxxxxxxxx, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, x86@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx Tony Luck" <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20110623114536.GA14011@linux-mips.org> <4E032940.5010205@ge.com> <20110623120234.GA22524@linux-mips.org> <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote:
> > (Adding the PPC folks to cc.)
> >
> > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so
> > I don't think the driver will build there. I don't have a PPC toolchain
> > to verify that.
>
> I can verify it fails on PPC as well:
>
> drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
> drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in
>
> However, we do have a #define for PAGE_KERNEL_NC.
Do you think this driver in it's current stage is so valuable that some
ifdefery to get it to work on PPC is the way to go?
IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too.
But preferably the driver should be sorted out properly and until the v1
of my patch which disables it on all architectures that don't provide a
PAGE_KERNEL_NOCACHE definition will do just fine.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]