Re: [PATCH] atomic: add *_dec_not_zero
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sven Eckelmann <sven@xxxxxxxxxxxxx>
- Subject: Re: [PATCH] atomic: add *_dec_not_zero
- From: Mike Frysinger <vapier.adi@xxxxxxxxx>
- Date: Sun, 8 May 2011 22:38:43 -0400
- Cc: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-m32r@xxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-cris-kernel@xxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Chris Metcalf <cmetcalf@xxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linux-am33-list@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- In-reply-to: <201105081133.50824.sven@xxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <1304458235-28473-1-git-send-email-sven@xxxxxxxxxxxxx> <20110508092403.GB27807@xxxxxxxxxxxxxxxxxxxxxx> <201105081133.50824.sven@xxxxxxxxxxxxx>
On Sun, May 8, 2011 at 05:33, Sven Eckelmann wrote:
> Russell King - ARM Linux wrote:
> [...]
>> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no
>> generic header which it could be added to?
>
> Mike Frysinger already tried to answer it in
> <BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@xxxxxxxxxxxxxx>:
>> that's what asm-generic is for. Âif the arch isnt using it, it's
>> either because the arch needs to convert to it, or they're using SMP
>> and asm-generic doesnt yet support that for atomic.h.
>>
>> for example, the Blackfin port only needed updating for the SMP case.
>> in the non-SMP case, we're getting the def from asm-generic/atomic.h.
>
> Feel free to change that but I just followed the style used by all other
> macros and will not redesign the complete atomic*.h idea.
what you're doing is currently correct. i think merging SMP support
into asm-generic for atomic* will take a bit of pondering first.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]