> Oh....then would you like to create a new branch for stuff' like lockdep? > It would be very helpful for me. I'm not quite sure how a branch for which you are the only real user will help. Unless you know of some other people waiting to jump on and help once they see this patch in a tree? >I noticed that there is a Macro in INIT_TASK that has softirqs_enable >initialized to 1. (by default it is 0 ,which is copied from >INIT_TASK). Both softirqs_enabled and hardirqs_enabled must be >explicitly initialized to 1 in relavent kenrel paths by the lockdep >and irqflag trace patch. I still need to find a right place to do >that. > Why is ia64 different ... it seems odd that other architectures haven't run in to this. If ia64 is the only one that needs it, then it should be in some ia64 specific place - or failing that done in a way that gives me confidence that it is a nop on the other architectures (so I don't get blamed for breaking them). Same argument for MAX_LOCKDEP_KEYS_BITS which you reduce from 13 to 12 (percpu space is limited on ia64 - but that doesn't justify reducing this for everyone else). Is there some ia64 arch file in which we could define this, and then make the generic linux/lockdep.h file have #ifndef MAX_LOCKDEP_KEYS_BITS #define MAX_LOCKDEP_KEYS_BITS 13 #endif ??? > Do you want me to fix this as the first step to merge? Yes - we need to have cleaner changes to the generic files that are part of this patch first. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|