RE: [RFC trollpatch 1/1] genirq: Remove the fits all and nothing __do_IRQ() code
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Luck, Tony" <tony.luck@xxxxxxxxx>
- Subject: RE: [RFC trollpatch 1/1] genirq: Remove the fits all and nothing __do_IRQ() code
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Mon, 27 Sep 2010 20:49:49 +0200 (CEST)
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, "linux-alpha@xxxxxxxxxxxxxxx" <linux-alpha@xxxxxxxxxxxxxxx>, "linux-cris-kernel@xxxxxxxx" <linux-cris-kernel@xxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>, Hirokazu Takata <takata@xxxxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, "linux-parisc@xxxxxxxxxxxxxxx" <linux-parisc@xxxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>
- In-reply-to: <987664A83D2D224EAE907B061CE93D5301604712B4@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20100908152036.643594727@xxxxxxxxxxxxx> <AANLkTikVHO9DmyTX==CwViDK1rP0masBwjMakHZ0U=kZ@xxxxxxxxxxxxxx> <alpine.LFD.2.00.1009271953390.2416@xxxxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301604712B4@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Mon, 27 Sep 2010, Luck, Tony wrote:
> > No, it's deliberate. The solution is to use the correct flow handler
> > for your device. We have currently several flow handlers implemented:
>
> Yes, I found the different "handle_*_irq()" functions. The _percpu_
> variant works fine for the ia64 per-cpu interrupt paths.
>
> But *NONE* of them call desc->chip->end() (even though the code flow
> in Documentation/DcoBook/genericirq.tmpl says that three of them do
> call it]. So it appears that this was thought to be necessary when
> the docs were written, but was not put into the code.
Yeah, sorry.
> The ia64 chip->end function for edge triggered interrupts is a nop(),
> so handle_edge_irq() ought to work just fine for it [can't confirm
> from my initial tests because the HP box I'm using only has level
> triggered ones].
>
> handle_level_irq() works for my level triggered interrupts if I add
> a "desc->chip->end(irq)" call to it.
Hmm, why isn't chip->unmask() sufficient ?
> git grep "chip->end" appears to show that the only use of chip->end
> is in the "Recovery handler for misrouted interrupts": try_one_irq()
Right, that's just due to the old __do_IRQ() compability.
> At minimum we seem to have some documentation inconsistencies with
> the code.
Will fix.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]